wprig icon indicating copy to clipboard operation
wprig copied to clipboard
verified publisher icon wprig

Theme Check: missing required CSS classes

Open benoitchantre opened this issue 7 years ago • 5 comments

Issue Overview

The Theme Check plugin found that the following required classes are missing.

  • .sticky css class is needed in your theme css
  • .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.

benoitchantre avatar Mar 18 '19 21:03 benoitchantre

.screen-reader-text is apparently not detected. It is already in global.css

benoitchantre avatar Apr 09 '19 21:04 benoitchantre

Is there a way to run the theme check as part of the gulp/build process?

ataylorme avatar Apr 12 '19 03:04 ataylorme

I had a discussion with @dingo-d (Theme Sniffer lead dev) in Slack. #161 and #162 go in that direction.

  • #161 should be updated soon
  • #162 is blocked by https://github.com/squizlabs/PHP_CodeSniffer/issues/2197 (Greg or Juliette will be pinged)

benoitchantre avatar Apr 18 '19 11:04 benoitchantre

This was not fixed in 2.0, so moving to Future Release.

felixarntz avatar Jun 23 '19 16:06 felixarntz

We had a chat about the standards, and after we release v0.2.0 of the themes standard, we'll move it to a separate repo, so once we release 0.2.0 (hopefully this week) I'll update the PR, and then after we move them, I can make new update in the future release 🙂

dingo-d avatar Jun 24 '19 04:06 dingo-d