meta-box icon indicating copy to clipboard operation
meta-box copied to clipboard

CSS Flex layout questions in 5.4.4

Open thefrosty opened this issue 4 years ago • 1 comments

Note, the following is just questions on CSS changes to flex and how they look in our install at the moment.

Issue Overview

Getting some odd formatting after change to flex layout change found here: https://github.com/wpmetabox/meta-box/commit/b07658edf1b4c0c05d8fae6115c59ba99b07d2ad#diff-1fc556f95754ee7e33d91044125c44bb9f750c99be4406756ffb27413adfcaf5R14

Steps to Reproduce (for bugs)

See attached screenshots of all fields now forced to 100%.

First screenshot shows a pencil edit icon that is hooked on 'rwmb_' . $field_type . '_html' (post and select_advanced).

Second screenshot shows were we also have notices that were formatted correct, but are forced right now (using rwmb_wrapper_html hook for after images notice)

Third screenshot show input fields now at 100% not honoring the size attribute, and a multi select (advanced) also at 100%.

Fourth shows how odd the Key/Value CSS change is.

Screen Shot 2021-07-07 at 12 57 38 PM Screen Shot 2021-07-07 at 12 57 31 PM Screen Shot 2021-07-08 at 8 21 25 AM Screen Shot 2021-07-08 at 8 36 41 AM

thefrosty avatar Jul 08 '21 15:07 thefrosty

Hi,

Thanks for your feedback.

The previous changes are actually 2 changes:

  1. Inputs are 100% width, and
  2. Use flexbox for fields

Can you let me know how did you hook in your 1st and 2nd problems?

For the 3rd problem, can you share the code of the fields? Basically, inputs will honor the size attribute.

I'll check the 4th problem.

rilwis avatar Jul 09 '21 09:07 rilwis