vscode-wpilib icon indicating copy to clipboard operation
vscode-wpilib copied to clipboard

Detect romi project during project import

Open jpokornyiii opened this issue 2 years ago • 4 comments

When I tried importing some older romi projects, it wiped out my environment variable and simulation extension. I needed to add them back manually. Can these lines be added to the build.gradle file for romi projects? Basically, this:

dependencies { ... simulation wpi.deps.sim.ws_client(wpi.platforms.desktop, false) }

sim { envVar "HALSIMWS_HOST", "10.0.0.2" }

Needs to translate to this:

wpi.sim.addWebsocketsClient().defaultEnabled = true wpi.sim.envVar("HALSIMWS_HOST", "10.0.0.2")

jpokornyiii avatar Mar 31 '22 19:03 jpokornyiii

I believe this is what led to the confusion in https://github.com/wpilibsuite/WPILibPi/issues/222

jpokornyiii avatar Mar 31 '22 19:03 jpokornyiii

This is actually caused by the project importer not knowing about romi projects, and just assuming its a normal robot project. For 2023 I can investigate making the importer detect romi projects, and use the romi templates instead of the normal templates.

ThadHouse avatar Mar 31 '22 19:03 ThadHouse

Gotcha. Yeah, can we add this to the backlog of 2023 work? Let me know if you need help.

jpokornyiii avatar Mar 31 '22 19:03 jpokornyiii

#544 does the manually, but not automatically

sciencewhiz avatar Oct 30 '22 03:10 sciencewhiz