vscode-wpilib icon indicating copy to clipboard operation
vscode-wpilib copied to clipboard

remove required vendordep.json properties which aren't used and aren't required

Open ggoebel opened this issue 6 years ago • 1 comments

vendordeps phoenix.json and navx_frc.json aren't using:

  • isHeaderOnly
  • hasSources
  • skipOnUnknownClassifier
  • validClassifiers
  • sourcesClassifier

The following patch will prevent the wpilib-vscode extension from identifying these absences as problems. I.e. we can't control 3rd party vendor errors. So please stop polluting our ide with errors which we can't control and have to ignore.

ggoebel avatar Feb 05 '19 15:02 ggoebel

Instead of just removing, the validation should be updated to the new specification. What GradleRio expects can be found here

https://github.com/wpilibsuite/GradleRIO/blob/master/src/main/groovy/edu/wpi/first/gradlerio/wpi/dependencies/WPIVendorDepsExtension.groovy#L185

ThadHouse avatar Feb 05 '19 16:02 ThadHouse