ntcore icon indicating copy to clipboard operation
ntcore copied to clipboard

DeleteAllEntries subtle bug

Open virtuald opened this issue 6 years ago • 1 comments

Checks for m_entries.empty() and returns if so. This is incorrect as deleted entries could exist -- and if they did exist, then an outgoing clearEntries message would be sent, which doesn't seem to be intended (though it probably wouldn't cause any harm).

Probably deleteAllEntriesImpl should return true if it deleted something.

virtuald avatar Oct 04 '17 06:10 virtuald