frc-characterization
frc-characterization copied to clipboard
wpilibsuite
Docs are incorrect about python version
I tried using this with Python 3.6 and ran into an issue with importlib.resources not being found. I then updated to Python 3.8 and had problems installing robotpy-characterization. 3.7 seems to be the Goldilocks version, though the docs say 3.6 and greater.
Yes, 3.8 is broken - statsmodels is unable to install, I discovered this independently last night. I'll update the dependency list and docs accordingly.
Numpy has released for 3.8 put matplotlib has not. Seems like the readmes should be updated to suggest exactly 3.7 until matplotlib 3.2 is released. The PyPI package specifies 3.7 so the current readme note about 3.6 definitely needs to be updated.
Looks like statsmodels also doesn't have a release that works on 3.8 yet. This issue suggests that version 11 will likely support 3.8: https://github.com/statsmodels/statsmodels/issues/6220 The described workaround there did not work for me to get statsmodels running on 3.8
The frc-docs articles about this state clearly that only Python 3.7 should be used. So this has been resolved and can be closed. If someone wants to check if the dependency now has a 3.8 version, go for it!
Both numpy and statsmodels seem to support Python 3.9 now. Are there any plans to support Python 3.9?
I could help test anything that needs testing but I don't have access to a robot right now.
This tool will be replaced with https://github.com/wpilibsuite/sysid for the 2022 season so there probably isn't a need to update it for Python 3.9 support.
The upgrade itself isn't hard, but frc-characterization has no unit tests or integration tests, so making sure we didn't break something more on Windows, macOS, or Linux is difficult.