allwpilib icon indicating copy to clipboard operation
allwpilib copied to clipboard

imgui libraries are not published

Open Gold856 opened this issue 1 year ago • 3 comments
trafficstars

We only publish headers and source. I'm not actually sure if we need to publish those libraries (are there any downstream consumers?) We should either remove publishing completely or publish native libraries.

Gold856 avatar Oct 21 '24 13:10 Gold856

I would like to wrap the imgui/wpigui combination in python at some point, so I'll probably complain about that when I get to it.

There are various imgui python wrappers, but many are unmaintained or are out of date or only support some platforms.

virtuald avatar Oct 21 '24 13:10 virtuald

I thought we statically linked the imgui libraries into the wpigui library--if that's not the case, we should definitely publish them.

PeterJohnson avatar Oct 21 '24 14:10 PeterJohnson

I checked the wpigui libraries, and we do statically link imgui into wpigui. It's just that the headers and source for imgui are located elsewhere edu/wpi/first/thirdparty/imguiSuite/imguiSuite-cpp. It's a bit confusing though to have the headers split across two different places.

Gold856 avatar Oct 21 '24 15:10 Gold856