allwpilib icon indicating copy to clipboard operation
allwpilib copied to clipboard

Make SimpleMotorFeedforward only support discrete feedforward

Open narmstro2020 opened this issue 3 months ago • 29 comments

This PR sets period as a constructor argument along with adding another constructor overload to accomodate.
The constructor now creates the feedforward, plant, r and nextR variables used by the calculate(current, next, dtSeconds) overload.

The calculate(current, next, dtSeconds) overload is now calculateDiscrete(current, next).
The calculate(velocity, acceleration) overload is not calculateContinuous(velocity, acceleration).
The calculate(velocity) overload is unchanged. I'm not married to these name changes.

I will eventually move on to Elevator and Arm and C++ for all 3 based on the feedback I receive.

narmstro2020 avatar May 22 '24 17:05 narmstro2020