allwpilib icon indicating copy to clipboard operation
allwpilib copied to clipboard

Glass should complain if labels exceed 128 chars

Open truher opened this issue 11 months ago • 0 comments

in Window.cpp:66 Display(), a label is constructed which is a composite key of name (which is by default the NT id) and id. this label is later split in Storage.cpp:298 GetChild(). If the NT id is longer than 62 chars, the composite key is truncated, and that can cause id collisions, which does weird things: one window trying to display two things, for example.

it would be great if glass would simply explode if the keys were too long, "let it crash" style, pointing out the offending key.

then i'd know to fix it.

i mean it would be really great if there were no such length restriction, or some sort of warning, or whatever, but exploding is just as good

truher avatar Mar 08 '24 03:03 truher