PathWeaver icon indicating copy to clipboard operation
PathWeaver copied to clipboard

Display robot outline

Open andrewda opened this issue 7 years ago • 8 comments

Description

Closes https://github.com/wpilibsuite/PathWeaver/issues/47

This PR makes it easier to see the robot's state at any given waypoint and makes it easier for the user to estimate what field obstacles a robot may run into while traveling through its path. To do this, it adds two properties to the settings which control the robot's dimensions.

Screenshots

Create Project

User can specify robot width and height.

image

Path Viewer

image

andrewda avatar Oct 09 '18 04:10 andrewda

Thanks for working on this! Right now we're focusing on getting PR #96 ready for beta which is coming up shortly. Once that's in, we should figure out how to integrate this PR as there is some overlap.

kjrobrien avatar Oct 10 '18 19:10 kjrobrien

Here's how it's looking after the pathfinder integration:

image

andrewda avatar Oct 11 '18 18:10 andrewda

So a recent PR added the ability to edit your project (it loads your current values into the Create Project screen essentially). Can you add the new Preferences here as well: https://github.com/wpilibsuite/PathWeaver/blob/master/src/main/java/edu/wpi/first/pathweaver/CreateProjectController.java#L115

kjrobrien avatar Oct 11 '18 18:10 kjrobrien

Whoops, looks like I totally missed that! Fixed 😄

andrewda avatar Oct 11 '18 19:10 andrewda

What is the status of this PR is it ready to be reviewed/merged?

jasondaming avatar Mar 19 '21 15:03 jasondaming

Good question -- it's been a while! Not sure how bad the conflicts are, but last I remember this was ready to go.

andrewda avatar Mar 19 '21 16:03 andrewda

Do you want to handle the conflicts or do you want/need me to take this over?

jasondaming avatar Mar 19 '21 18:03 jasondaming

this would be mega useful

mxgordon avatar Dec 09 '21 23:12 mxgordon