William Hicks
William Hicks
@RAMitchell I'd love to have your thoughts on this one if you have a moment.
Good enough for me!
@gpucibot merge
Just ran into this issue with the knowhere integration, as well. Would be a good thing to fix for consistency across ANN methods.
Apologies @Zekrom-7780! This came in while I was on vacation. The changes look very nice! At our internal meeting today, I'll check in with the team about what level of...
Thanks very much @Zekrom-7780! Could you add some very basic tests demonstrating that these methods work with a cuML estimator? No need to repeat all of the testing that already...
@Zekrom-7780 You can add a new file here: https://github.com/rapidsai/cuml/tree/branch-23.12/python/cuml/tests. And of course we'd be delighted if you want to pick up more issues! Thank you so much for this contribution....
Thanks, @Zekrom-7780! In terms of tests, I was thinking something that just performs a very basic test of functionality. I.e. You could basically directly borrow from Scikit-Learn [here](https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/model_selection/tests/test_search.py#L195-L217), but rather...