wpessers

Results 34 comments of wpessers

I've started looking into this. One thing I can say immediately is that `sqsExtractContextPropagationFromPayload` should not make a difference. This just influences **how** context propagation is done, and using sqs...

I have been able to reproduce this I think. I have this small example with 2 lambda functions. 1 is invoked through an http request (through apigateway), then sends an...

So reading this in the aws-lambda instrumentation readme: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-aws-lambda#context-propagation It seems to me that it is actually impossible to link the spans together if we're not using X-Ray 🤔

Agreed, going to do some more testing on this as the aws sdk instrumentation does seem to state the opposite: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-aws-sdk/doc/sqs.md#sendmessage--sendmessagebatch > OpenTelemetry trace context is injected as SQS MessageAttributes,...

Hi @gkaskonas I'm sorry for the late reply, have been quite busy but finally getting some more free time on my hands to look into this. Thanks @nic-littlepay for your...

I actually don't think aws sdk instrumentation currently supports EventBridge... I suppose that would be an issue to raise in the js-contrib repo. See: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-aws-sdk

Yes it should be, I was a little too quick to judge there but this seems fine. We've discussed this with other maintainers of the project and will be following...

@nic-littlepay I may be missing something in all the different options you've tried. But have you tried using the wrapper layer and then using the corresponding wrapper script through setting...

Hi, progress on this has been slow I know. But I've been looking into the actual sqs instrumentation code and came to the conclusion that that already works well. It...

Yep I think so too. I am discussing this with the js maintainers and will link issue as soon as we have one.