phpcompat icon indicating copy to clipboard operation
phpcompat copied to clipboard

False Positive: Revive Old Posts plugin

Open DougNix opened this issue 5 years ago • 1 comments

Please add this to the False Positives list.

Revive Old Posts by revive.social, https://wordpress.org/plugins/tweet-old-post/, generates the following errors:

FILE: /home/ms101admin/public_html/wp-content/plugins/tweet-old-post/vendor/facebook/graph-sdk/src/Facebook/PseudoRandomString/McryptPseudoRandomStringGenerator.php

FOUND 3 ERRORS AFFECTING 1 LINE

57 | ERROR | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead 57 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead 57 | ERROR | The constant "MCRYPT_DEV_URANDOM" is deprecated since PHP 7.1 and removed since PHP 7.2

According to the authors, this is a false positive. https://wordpress.org/support/topic/php-7-3-compatibility-22/#post-12267591

DougNix avatar Dec 24 '19 13:12 DougNix

The error is coming from the Facebook graph SDK which is a dependency of the plugin: https://github.com/facebook/php-graph-sdk/tree/5.x/src/Facebook/PseudoRandomString

Unless they update their SDK everyone using their SDK would get this error. The plugin doesn't necessarily make use of those functions, they just happen to be part of the Facebook SDK

UVLabs avatar Dec 24 '19 22:12 UVLabs