Whitelist of plugins that can cause false positives, not updated in 3 years

[the-de-coder]

"We maintain a whitelist of plugins that can cause false positives."

The list has not been updated in 3 years

[mindctrl]

Notes:

I think @the-de-coder is referring to the Wiki page here: https://github.com/wpengine/phpcompat/wiki/Results

The list in the plugin code is maintained here: https://github.com/wpengine/phpcompat/blob/b2ebb42fca884803c23b8451a2be082d256cac36/src/wpephpcompat.php

[the-de-coder]

When viewing the plugin main page, at the bottom of the screen under Limitations & Caveats, the first item is:

“This tool cannot detect unused code paths that might be used for backwards compatibility, potentially showing false positives. We maintain a whitelist of plugins that can cause false positives.”

Which links to a 3 year old page.

From: John Parris [mailto:[email protected]] Sent: Monday, August 26, 2019 10:16 AM To: wpengine/phpcompat Cc: De Coder; Mention Subject: Re: [wpengine/phpcompat] Whitelist of plugins that can cause false positives, not updated in 3 years (#246)

Notes:

I think @the-de-coder https://github.com/the-de-coder is referring to the Wiki page here: https://github.com/wpengine/phpcompat/wiki/Results

The list in the plugin code is maintained here: https://github.com/wpengine/phpcompat/blob/b2ebb42fca884803c23b8451a2be082d256cac36/src/wpephpcompat.php

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wpengine/phpcompat/issues/246?email_source=notifications&email_token=ABPHPKPILSFUAPOEVDAYNXTQGQFUFA5CNFSM4IPIBCZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FAW6I#issuecomment-524946297 , or mute the thread https://github.com/notifications/unsubscribe-auth/ABPHPKNF6N36SOL7RCNKN3LQGQFUFANCNFSM4IPIBCZQ . Web Bug from https://github.com/notifications/beacon/ABPHPKK4VJHYDIFWXZMRDVDQGQFUFA5CNFSM4IPIBCZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FAW6I.gif https://s3.amazonaws.com/msv5/images/spacer.gif

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/wpengine/phpcompat/issues/246?email_source=notifications\u0026email_token=ABPHPKPILSFUAPOEVDAYNXTQGQFUFA5CNFSM4IPIBCZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FAW6I#issuecomment-524946297", "url": "https://github.com/wpengine/phpcompat/issues/246?email_source=notifications\u0026email_token=ABPHPKPILSFUAPOEVDAYNXTQGQFUFA5CNFSM4IPIBCZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5FAW6I#issuecomment-524946297", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[richboos]

Yeah noticed this too. The plugin points to an outdated page. If it wasn't, I don't believe @the-de-coder would even have noticed the outdated page.

Discount Rules for WooCommerce can be added to the whitelist, allegedly, according to the author. https://wordpress.org/support/topic/failing-some-php-compatibility-checks/#post-13156449

This can also be added to the whitelist, I just browsed the code and it is also backwards compatibility related: https://wordpress.org/plugins/woocommerce-shipstation-integration/

I might be able to make a pull request for the latter, as I understand the nomenclature enough.