wpbonelli
wpbonelli
It seems like for stress period data, `.set_data()` has `dict.update()`-like semantics right now. The "blessed" way to drop keys seems to be to set them to `None`. But this is...
Agree with @dbrakenhoff I think lowest number is the existing convention so might as well stick to it if there is no performance cost?
> across all grid types > grids will never be non-convex and **always layered** does the latter mean the new grid index and related performance boost don't support DISU?
@aacovski I guess I just didn't properly understand what you meant by "always layered"
> The index shouldn’t assume that [the provided cell centers correspond to geometric centroids], so I’ll update to clarify how cell centers are interpreted. Ah, ok- and the index doesn't...
@aacovski it wasn't really clear from previous comment but I think it's best to revert the docstrings to say centroid rather than leaving it ambiguous. my first comment was really...
Another thought: why not move the structured grid searchsorted query implementation to `GeospatialIndex`? That way all the `Grid.intersect` methods could use the index. Since the index receives the grid on...
I'm pretty sure "cell centers" is meant as centroids, that's why I'm suggesting to change the doctrings up in the grids themselves. But I could be wrong. Hopefully someone with...
thanks @christianlangevin. so @aacovski the more general "cell centers" is better as you suggest. we may update the description upstream in mf6io but no need to change the grid docstrings...
> do we continue to let the two live side-by-side? I think this is fine. 4.x is a natural time for consolidation. at some point we'll need to make the...