wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

PHPCS configuration file: replace deprecated `Passing an array of values to a property using a comma-separated string`

Open remyperona opened this issue 8 months ago • 1 comments

Description

The old syntax for the config file using a string with comma-separated values was deprecated in PHPCS 3.3 and remove in PHPCS 4.0.

Type of change

  • [x] Chore

Detailed scenario

What was tested

Using the new syntax, there is no longer a deprecated warning when running PHPCS

How to test

Run PHPCS

Technical description

Documentation

Use element nodes instead of the old syntax to pass the values necessary.

Mandatory Checklist

Code validation

  • [x] I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • [x] I triggered all changed lines of code at least once without new errors/warnings/notices.
  • [x] I implemented built-in tests to cover the new/changed code.

Code style

  • [x] I wrote a self-explanatory code about what it does.
  • [x] I protected entry points against unexpected inputs.
  • [x] I did not introduce unnecessary complexity.
  • [x] Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

remyperona avatar May 16 '25 21:05 remyperona

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -0.10%) :white_check_mark: (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c046b5332ec1175a498d32765862d87be7a0112) 39079 17123 43.82%
Head commit (c42b16a19ef58882804b61b23f8ff4b93e82e344) 39079 (+0) 17123 (+0) 43.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7397) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

codacy-production[bot] avatar May 16 '25 21:05 codacy-production[bot]

For test: Run e2e smoke

Mai-Saad avatar Jul 17 '25 06:07 Mai-Saad

e2e smoke are green,

PHPCS is green as well,

Works properly.

Miraeld avatar Jul 25 '25 01:07 Miraeld