wp-rocket
wp-rocket copied to clipboard
wp-media
Cache table exists query duplication
Describe the bug
When visiting any admin page with Query Monitor plugin active, you will see in the section of duplicate queries the following:
To Reproduce Steps to reproduce the behavior:
- Install and activate
WP Rocket - Install and activate
Query Monitor - In any admin page, check the duplicate queries as in the above screenshot.
Expected behavior We shouldn't have any duplicate queries.
Additional context I believe this is because we initiate this cache table several times and the fix should be here:
https://github.com/wp-media/wp-rocket/blob/10a00a8d579106da31e34469a99aa050b46a9b28/inc/Engine/Preload/ServiceProvider.php#L67
It should use addShared instead of add because this table acts as a subscriber with some callbacks so we need to instantiate it only once.
