wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Revert "Fixes #6972 Prevent injecting Beacon script when DONOTROCKETOPTIMIZE is defined

Open wordpressfan opened this issue 1 year ago • 1 comments

This reverts commit 7f4f53305b790a2f010ec8d5734e2f6bf79ecea4.

Description

Fixes #(issue number) Explain how this code impacts users.

Type of change

  • [ ] New feature (non-breaking change which adds functionality).
  • [ ] Bug fix (non-breaking change which fixes an issue).
  • [ ] Enhancement (non-breaking change which improves an existing functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as before).
  • [ ] Sub-task of #(issue number)
  • [ ] Release

Detailed scenario

Explain how to reproduce the issue (for bugs) or how to trigger the new code. You can refer to the GitHub issue or grooming if it is still applicable.

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Mandatory Checklist

Code validation

  • [ ] I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • [ ] I triggered all changed lines of code at least once without new errors/warnings/notices.
  • [ ] I implemented built-in tests to cover the new/changed code.

Code style

  • [ ] I wrote a self-explanatory code about what it does.
  • [ ] I protected entry points against unexpected inputs.
  • [ ] I did not introduce unnecessary complexity.
  • [ ] Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • [ ] In the case of complex code, I wrote comments to explain it.
  • [ ] When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • [ ] I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

wordpressfan avatar Oct 17 '24 06:10 wordpressfan

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ce7b6014eba3777825b2a4cacf942f6b0e7300be[^1] :white_check_mark: (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce7b6014eba3777825b2a4cacf942f6b0e7300be) Report Missing Report Missing Report Missing
Head commit (e8e4395bfec012a0b94a24515397a0f8563a11c9) 37744 16585 43.94%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7037) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

codacy-production[bot] avatar Oct 17 '24 06:10 codacy-production[bot]