wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Closes #6914: URLs are not fetched when updating from 3.16+ to 3.17

Open Miraeld opened this issue 1 year ago • 2 comments

Description

Fixes #6914

Fetched URLs are added to the LRC table upon plugin update from 3.16+ to 3.17.

Type of change

  • [ ] New feature (non-breaking change which adds functionality).
  • [x] Bug fix (non-breaking change which fixes an issue).
  • [ ] Enhancement (non-breaking change which improves an existing functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as before).
  • [ ] Sub-task of #(issue number)
  • [ ] Release

Detailed scenario

Steps to reproduce the behavior:

Have any of the 3.16 versions of the plugin installed. Check the ATF table. => table contains warmup links. Update plugin to 3.17-alpha1 version. Check the LRC table for fetched URLs. => Table created but empty, no fetched URLs are added.

Technical description

Documentation

Just an update of the version.

New dependencies

Risks

Mandatory Checklist

Code validation

  • [x] I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • [x] I triggered all changed lines of code at least once without new errors/warnings/notices.
  • [x] I implemented built-in tests to cover the new/changed code.

Code style

  • [x] I wrote a self-explanatory code about what it does.
  • [x] I protected entry points against unexpected inputs.
  • [x] I did not introduce unnecessary complexity.
  • [x] Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • [x] In the case of complex code, I wrote comments to explain it.
  • [x] When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • [x] I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

Miraeld avatar Aug 29 '24 01:08 Miraeld

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 7999ed2618d11d7fa9b63fc78a7810789072d4b9[^1] :white_check_mark: 63.46% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7999ed2618d11d7fa9b63fc78a7810789072d4b9) Report Missing Report Missing Report Missing
Head commit (9b24ff266b7194f2c6060d210646ea360ee9ecb2) 37925 16540 43.61%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6926) 583 370 63.46%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

codacy-production[bot] avatar Aug 29 '24 01:08 codacy-production[bot]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -0.10%) :white_check_mark: 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (30fb031bdec014b237db7d0fcd6ec35090fbf7b4) 37925 16540 43.61%
Head commit (9b24ff266b7194f2c6060d210646ea360ee9ecb2) 37925 (+0) 16540 (+0) 43.61% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6926) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

codacy-production[bot] avatar Aug 29 '24 01:08 codacy-production[bot]

Thanks for the PR @Miraeld testrail-report-635.pdf

Working as expected.

jeawhanlee avatar Aug 30 '24 12:08 jeawhanlee