wp-rocket
wp-rocket copied to clipboard
wp-media
Hosting cache not cleared when clearing Performance Hints for current URL
Before submitting an issue please check that you’ve completed the following steps:
- Made sure you’re on the latest version ✓
3.17/6845-subtask-data-clearing-notices - Used the search feature to ensure that the bug hasn’t been reported before ✓
Describe the bug Hosting cache not cleared when clicking on "Clear Performance Hints for current URL" from admin page view.
To Reproduce Preconditions: Site hosted on Cloudways (https://cloudways.rocketlabsqa.ovh/) Preload disabled
Steps to reproduce the behavior:
- Cache a page with lcp or above the fold images. > The x-cache header's value should be HIT. If it isn't, hard refresh the page until it is
- From page view, click "Clear Performance Hints of this URL" then visit the page incognito.
- Check again the X-cache header's value. > See that value is still HIT.
Expected behavior The value of the X-cache header should be MISS after clicking on the "Clear Performance Hints of this URL".
Note: Using "Purge this URL" or "Clear Performance Hints data" will work.
Screenshots If applicable, add screenshots to help explain your problem.
Additional context Add any other context about the problem here.
Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming
Is this still an issue @hanna-meda after merging this https://github.com/wp-media/wp-rocket/pull/6886 ?
@Khadreal just tested with 3.17-alpha1 on cloudways.rocketlabsqa site and, unfortunately, the issue is still there
I think we need to add rocket_performance_hints_data_after_clearing in https://github.com/wp-media/wp-rocket/blob/fb50ef3b9db98b09b4b90797f5c16117a1560435/inc/ThirdParty/Plugins/CDN/Cloudflare.php#L76
Haven't been able to test it yet.
[Updated] This is wrong, I tested this and not related