wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Fixes #6392 Optimize WP Query in `rocket_url_to_postid()`

Open remyperona opened this issue 1 year ago • 1 comments

Description

Optimize the query by passing the args to prevent caching and found rows calculation.

Fixes #6392

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No grooming, small change.

Checklists

Generic development checklist

  • [x] My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • [x] The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • [x] I triggered all changed lines of code at least once without new errors/warnings/notices.
  • [ ] I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • [ ] I validated all test plan the QA Review asked me to.

remyperona avatar Jan 22 '24 20:01 remyperona

Related initial test plan https://wpmediaqa.testrail.io/index.php?/runs/view/816&group_by=cases:section_id&group_order=asc

Mai-Saad avatar Feb 14 '24 12:02 Mai-Saad

Moved this to QA done for now without merging it until we check the 2 blocked tests in here.

hanna-meda avatar Feb 28 '24 16:02 hanna-meda