wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

license validation fails after WP Engine migration to staging

Open worldwildweb opened this issue 2 years ago • 3 comments

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version ✅
  • Used the search feature to ensure that the bug hasn’t been reported before ✅

Describe the bug WP Engine changes the consumer_email value in the wp_rocket_settings option from the wp_options table during the migration to staging which requires the user or support to intervene to resolve this issue.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior The consumer_email value shouldn't be modified so the license is validated without manual intervention.

Screenshots Screenshot 2023-09-02 at 12 11 00 copy

Additional context Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

worldwildweb avatar Sep 02 '23 10:09 worldwildweb

Think it might be the same as: https://github.com/wp-media/wp-rocket/issues/2804

webtrainingwheels avatar Sep 02 '23 15:09 webtrainingwheels

@DahmaniAdame what do you think about hashing those values? It'd prevent from doing unintentional rewrites during search and replace when the website domain matches email domain 🤔

piotrbak avatar Sep 07 '23 12:09 piotrbak

Yes. That would solve it for similar cases linked to hosting services or even cloning or migration plugins.

DahmaniAdame avatar Sep 07 '23 14:09 DahmaniAdame