wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Display a Divi recommended configuration notification

Open WordPresseur opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. A lot of common customers with Divi will duplicate Divi's Performances features and WP Rocket's features. They'll never be aware about our recommendations regarding Divi unless they contact support.

Most of the time, applying these recommendations, fixes the issues and increase performances.

Describe the solution you'd like Since that's the only theme in our Compatibility > Theme section, maybe it would worth to display a notification when we detect Divi.

image

Additional context Typical HS ticket: https://secure.helpscout.net/conversation/2281052724/426306/

WordPresseur avatar Jun 26 '23 09:06 WordPresseur

@DahmaniAdame Here it could be better to force customers to use only one feature. Are we okay with this? https://github.com/wp-media/wp-rocket/blob/9bdfa2f8d74c612101b3776c710270a2d171faa6/inc/admin/ui/notices.php#L154-L191

piotrbak avatar Jul 25 '23 15:07 piotrbak

@piotrbak what do you mean by that?

DahmaniAdame avatar Jul 26 '23 07:07 DahmaniAdame

@DahmaniAdame Ah, the array I mentioned won't be useful in this case. What I meant is that we could do just like we do for Avada. If we detect a specific option enabled we'd either disable ours with a message or force using WP Rocket's feature: https://github.com/wp-media/wp-rocket/blob/9bdfa2f8d74c612101b3776c710270a2d171faa6/inc/ThirdParty/Themes/Avada.php#L105-L118 As per: image

piotrbak avatar Jul 26 '23 08:07 piotrbak