wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Error displayed when enable CF optimal settings + add key data at the same time

Open Mai-Saad opened this issue 2 years ago • 1 comments

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => 3.14
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug Error notice is displayed when enabling optimal settings at the time we add the CF addon data

To Reproduce Steps to reproduce the behavior:

  1. Fresh install/ activation of 3.14
  2. Enable the CF addon
  3. Click Modify options
  4. Add valid key, id, and email and enable optimal settings then save => error displayed

Expected behavior No error is displayed as the data is valid

Screenshots If applicable, add screenshots to help explain your problem. Screenshot from 2023-06-19 11-17-17

Backlog Grooming (for WP Media dev team use only)

  • [ ] Reproduce the problem
  • [ ] Identify the root cause
  • [ ] Scope a solution
  • [ ] Estimate the effort

Mai-Saad avatar Jun 19 '23 08:06 Mai-Saad

A possible variant of this issue here: https://secure.helpscout.net/conversation/2591270980/490366?folderId=2952229

In this case, when you try activating the CF Addon with all the toggles disabled, and adding the correct CF credentials, you get only one error: Missing Cloudfare Zone ID

Logging the values, the $zone_id is empty at is_auth_valid() and also the values at save_cloudflare_options().

Enabling Optimal Settings before saving, allowed the addon activation

Related Slack Thread https://wp-media.slack.com/archives/C43T1AYMQ/p1715197524274279

alfonso100 avatar May 13 '24 13:05 alfonso100

We did not have enough feedback from customers related to this issue. We might reopen this in the future.

piotrbak avatar Jun 28 '24 13:06 piotrbak