wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Fix undefined WPR_WEBP env var

Open dvershinin opened this issue 1 year ago • 4 comments

Improves readability of .htaccess by preventing the inclusion of undefined WPR_WEBP environment variable when WebP caching is disabled.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [x ] New and existing unit tests pass locally with my changes

dvershinin avatar Nov 10 '22 10:11 dvershinin

@Roy-Orbison updated with the suggestion and squashed it into a single commit.

dvershinin avatar Sep 03 '23 17:09 dvershinin

@Roy-Orbison can we have this merged now? Thank you in advance :-)

dvershinin avatar Oct 17 '23 05:10 dvershinin

@dvershinin I don't work for them, sorry. I just read your commit when I was doing one myself (#6123).

Roy-Orbison avatar Oct 17 '23 05:10 Roy-Orbison

Oh, I see. @engahmeds3ed would you take a look, please? We're working on a converter for Apache configurations, and this is one of the issues somewhat critical for us.

dvershinin avatar Oct 17 '23 05:10 dvershinin