wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Closes #5149 - remove wpr options from not public post types

Open jeawhanlee opened this issue 2 years ago • 5 comments

Description

This PR removes WPR options on non public post types.

Fixes #5149

Type of change

  • [x] Enhancement (non-breaking change which improves an existing functionality)

Checklist:

Please delete the options that are not relevant.

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings

jeawhanlee avatar Jul 07 '22 18:07 jeawhanlee

@jeawhanlee Can see a Clear cache option for the draft post list, at the admin bar of the edit draft post, and, if the classic editor is used, can see a clear cache option inside the page edit view. Can you please check?

2022-09-02 (2) 2022-09-02 (3) 2022-09-02 (4)

@piotrbak shouldn't we remove the option from the trash post list? 2022-09-02 (5)

Mai-Saad avatar Sep 02 '22 06:09 Mai-Saad

@jeawhanlee Thanks for the update, I can see most of the cases working now. only the ADD new page now while using classic editor contains a clear cache option (page/post still not saved as draft nor published yet), can we handle this case? Screenshot from 2022-09-07 18-38-01

Note: there is a warning on the branch, still under investigation to get consistent reproducible steps (started discussion here )

Mai-Saad avatar Sep 07 '22 17:09 Mai-Saad

Working fine to clear the cache. Remain only, removing clear used CSS of this URL for the non-public post in preview or view page + checking the same case for Elementor template view @jeawhanlee can you please check Note: update for test cases is needed testrail-report-410.pdf

Mai-Saad avatar Sep 09 '22 11:09 Mai-Saad

@jeawhanlee can we handle Clear used of this URL not showing for private pages on the same PR?

Mai-Saad avatar Sep 09 '22 11:09 Mai-Saad

What's remaining to be handled: scenario1: 1- create any post 2- from quick edit, check private 3- from the posts list click view for this post 4- hover on the admin bar

Scenario 2: 1- Create an Elementor template (published one) 2- click preview from the template list 3- hover the admin bar

Mai-Saad avatar Sep 09 '22 16:09 Mai-Saad