wp-rocket
wp-rocket copied to clipboard
Close #5098 - Fixed warning in Image dimensions when loading certain SVG
Description
This issue fix a warning that comes from Image Dimensions when loading certain SVG for that we add configuration to ignore warnings on the function loading the SVG.
Fixes #5098
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
Is the solution different from the one proposed during the grooming?
No.
How Has This Been Tested?
- [ ] Manual Test in local
Checklist:
Please delete the options that are not relevant.
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
That's a good solution. do u think we need to use the function
rocket_get_constant
while calling those constants?I tried to search to find if those constants are system-specific so we may find a system that doesn't have those constants but I didn't find anything like that.
So I believe we are fine but wanted to share thoughts with u, what do u think?
I will check what is the value from theses constants and use rocket_get_constant
to set them as default if they don't exist. I think that would fix the problem.
32 and 64