wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Closes #4905 Minimalist blogger thirdparty class for delay JS compatibility

Open CrochetFeve0251 opened this issue 2 years ago • 1 comments

Description

Fix a problem with jQuery in Minimalist Blogger when Delay JS is activated by excluding jQuery from delayed scripts when the theme is active.

Fixes #4905

Type of change

Please delete options that are not relevant.

  • [ ] Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

  • [x] Automated tests

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

CrochetFeve0251 avatar Jun 10 '22 14:06 CrochetFeve0251

@Tabrisrp @piotrbak the cleaned branche

CrochetFeve0251 avatar Jun 10 '22 15:06 CrochetFeve0251

@CrochetFeve0251 can still see the error on newlabs using the theme https://pcm.wordpress.org/themes/minimalistblogger/. can you please check? Screenshot from 2022-09-07 08-41-19

Mai-Saad avatar Sep 02 '22 11:09 Mai-Saad

@Mai-Saad I'm not able to reproduce the problem. Excluding jQuery resolves the problem for me here: https://rocketlabsqa.ovh

piotrbak avatar Sep 06 '22 17:09 piotrbak

Working fine now

Mai-Saad avatar Sep 09 '22 15:09 Mai-Saad

@CrochetFeve0251 I retested this after the latest changes and it's working as expected.

Please merge it whenever you can.

vmanthos avatar Sep 12 '22 11:09 vmanthos