imagify-plugin icon indicating copy to clipboard operation
imagify-plugin copied to clipboard

Delete next-gen or webP isnot displayed for optimized images

Open Mai-Saad opened this issue 1 year ago • 3 comments

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => 2.1.3.1
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug Delete webP image isnot displayed in media library for optimized images as same as it is displayed for already optimized images (on 2.2 delete next-gen won't be displayed in the same scenario)

To Reproduce Steps to reproduce the behavior:

  1. 2.1.3 installed and activated
  2. Create webP is enabled
  3. upload image (small, medium , large)
  4. notice delete webP link only displayed for small image that is already optimized and not displayed to other 2 images

Expected behavior Delete link is displayed as long as webp on 2.1.3.1 or next-gen is generated as per enabled option on 2.2

Screenshots If applicable, add screenshots to help explain your problem. Screenshot from 2024-02-29 08-37-53

Additional context Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

Mai-Saad avatar Feb 29 '24 06:02 Mai-Saad

isn't it normal? I don't know what were the original expectations when implementing WebP at the time, but I see it as this:

  • If image already optimzed, there is no original to restore, but there can be WebP images to delete
  • If image is optimized, restore original will both do that and delete the WebP images

The end result is the same for both cases, only the original image remains.

@piotrbak

remyperona avatar Mar 01 '24 17:03 remyperona

@Tabrisrp Thanks for the bigger picture of this use case. We'll need to discuss within the team a couple of scenarios similar to this one.

piotrbak avatar Mar 03 '24 17:03 piotrbak

related to https://github.com/wp-media/imagify-plugin/issues/812

Mai-Saad avatar Mar 08 '24 11:03 Mai-Saad