imagify-plugin icon indicating copy to clipboard operation
imagify-plugin copied to clipboard

File type isnot valid in media library when upload AVIF image

Open Mai-Saad opened this issue 1 year ago • 4 comments

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => Avif commit: https://github.com/wp-media/imagify-plugin/commit/b396de27cda71d9b16e311a0f55f482bebf13380
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug When uploading AVIF image then go to the media library, the status will be File type image/avif is not valid.

To Reproduce Steps to reproduce the behavior:

  1. Fresh install
  2. upload AVIF image
  3. Go to media library

Expected behavior

  • Thumbnail is generated
  • If AVIF is disabled, WebP is generated
  • If AVIF is enabled, and the filter to create webP is on then webp is generated

Screenshots If applicable, add screenshots to help explain your problem. Screenshot from 2024-02-05 13-45-27

Additional context Add any other context about the problem here.

  • on trunk, if we uploaded webP while generate webP is enabled, we create the thumbnail for that image
  • on trunk, if we uploaded AVIF image, in media library we display, media isnot supported (however we support AVIF now)

Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming

Mai-Saad avatar Feb 05 '24 12:02 Mai-Saad

@piotrbak @MathieuLamiot I'm not sure what the expectations are here:

  • WordPress currently doesn't support AVIF upload (coming in 6.5 https://core.trac.wordpress.org/ticket/51228)
  • Does Imagify support optimizing AVIF images? It supports convertion from another format, but I'm not sure for direct AVIF

remyperona avatar Feb 15 '24 20:02 remyperona

@Tabrisrp Thanks! Let's not touch it in the 2.2.

@Mai-Saad how were you able to upload AVIF? Which environment was used there?

piotrbak avatar Feb 15 '24 20:02 piotrbak

@Mai-Saad how were you able to upload AVIF? Which environment was used there?

@piotrbak on https://imagify.rocketlabsqa.ovh/ using WP 6.5-beta1-57656

Mai-Saad avatar Feb 20 '24 08:02 Mai-Saad

@Mai-Saad That's why. Let's leave it for the future enhancement

piotrbak avatar Feb 20 '24 09:02 piotrbak