wp-graphql-jwt-authentication icon indicating copy to clipboard operation
wp-graphql-jwt-authentication copied to clipboard

Published 20 hours ago • verified publisher icon wp-graphql

fix(response headers): replace single header instead of overwriting them all

Open tsmith-rv opened this issue 4 years ago • 3 comments

updated to call the 'header' instead of 'set_headers' method when writing response headers to avoid overwriting all the headers such as X-WP-Total and X-WP-TotalPages which are necessary for different plugins and pieces of Wordpress to work properly

tsmith-rv avatar Nov 04 '20 13:11 tsmith-rv

Hi @jasonbahl this fixes some issues for me and from what I see for other folks, do you think you can merge it or do you see any side effects?

rodrigo-arias avatar Jun 17 '22 21:06 rodrigo-arias

We have the same issues this plugin is breaking some of our REST API apps

matthijs166 avatar Jul 01 '22 12:07 matthijs166

Would love to see this merged, currently Woocommerce Analytics is partly broken because of this. 👀

kpoelhekke avatar Aug 26 '22 13:08 kpoelhekke

Coming up on the 2 year anniversary of when I opened this PR — not quite sure how I'll celebrate yet. I'm pretty low key, but it never hurts to go all out every once in a while.

tsmith-rv avatar Oct 25 '22 14:10 tsmith-rv

@tsmith-rv 🥳

jasonbahl avatar Oct 25 '22 14:10 jasonbahl

Released: https://github.com/wp-graphql/wp-graphql-jwt-authentication/releases/tag/v0.6.0

jasonbahl avatar Oct 25 '22 14:10 jasonbahl