WP-e-Commerce icon indicating copy to clipboard operation
WP-e-Commerce copied to clipboard

Categories view mode

Open mihaijoldis opened this issue 10 years ago • 6 comments

Fixes display type for categories overwriting the Presentation settings when selecting Default as option

mihaijoldis avatar Feb 07 '15 18:02 mihaijoldis

Is there an issue on Github for this PR?

JustinSainton avatar Feb 07 '15 19:02 JustinSainton

#1505 perhaps?

JustinSainton avatar Feb 07 '15 19:02 JustinSainton

Even after using the code change above SOME of the categories might have the display_type set in the meta table. To make sure the code change above will work correctly for existing categories that already have that in the DB i ran a sql query to remove all meta for existing categories that used the DEFAUL view mode:

DELETE FROM `wp_wpsc_meta` WHERE `meta_key` = 'display_type' AND `meta_value` = 'default'

mihaijoldis avatar Feb 07 '15 20:02 mihaijoldis

Sounds like we need an upgrade routine here before we can merge.

JustinSainton avatar Jun 06 '15 20:06 JustinSainton

Just remembered this PR existed :) A couple things, if we want to land #1505 in 4.0

  • rather than using esc_sql(), let's check against a filtered array, containing grid/list.
  • as mentioned, we'll need an upgrade routine.

JustinSainton avatar Jun 23 '15 06:06 JustinSainton

Punting this to 4.1, pending the required changes.

JustinSainton avatar Jul 02 '15 05:07 JustinSainton