scaffold-package-command icon indicating copy to clipboard operation
scaffold-package-command copied to clipboard

Update templated requirements to current releases

Open BrianHenryIE opened this issue 1 year ago • 4 comments

scaffold-package-command generates a composer.json using relatively old package versions.

https://github.com/wp-cli/scaffold-package-command/blob/c309cf58b5dee0428fa05c45dbf094bb7c2c5c6f/templates/composer.mustache#L8-L13

This PR updates the defaults provided in the PhpDoc to the current releases:

BrianHenryIE avatar Aug 03 '24 05:08 BrianHenryIE

Feature tests should also be updated. May be we can wait for "2.11" which is going to released in a couple of days.

ernilambar avatar Aug 03 '24 06:08 ernilambar

No urgency, but I'm not sure what exactly you're referring to with "Feature tests".

Really, the wp-cli/wp-cli update from ^2.5 to ^2.10.0 won't make a practical difference, wp-cli/wp-cli-tests from ^3.0.11 to ^4.3.1 (^4) is where I noticed an issue.

Edit: tests are failing anyway, I'll have to spend more time on this!

BrianHenryIE avatar Aug 03 '24 06:08 BrianHenryIE

https://github.com/wp-cli/scaffold-package-command/blob/main/features/scaffold-package-readme.feature#L43 should also be updated with new value.

ernilambar avatar Aug 04 '24 09:08 ernilambar

WP-CLI 2.11 has been released.

ernilambar avatar Aug 08 '24 05:08 ernilambar

I think I accidentally fixed this in #253, apologies for missing this PR!

swissspidy avatar Mar 31 '25 08:03 swissspidy