scaffold-command icon indicating copy to clipboard operation
scaffold-command copied to clipboard

Better way to execute the install command

Open zaherg opened this issue 4 years ago • 2 comments

This will change the command from:

"usage: $0 <db-name> <db-user> <db-pass> [db-host] [wp-version] [skip-database-creation]"

to

"Usage: $0 -d <db-name> -u <db-user> -p <db-pass> -h [db-host] -v [wp-version] -s [skip-database-creation]";

Which will make it easier/simpler to understand and even mix the parameters without any problems, so they can run it like:

./templates/install-wp-tests.sh -d db_name -u my_user -p my_super_secret_password

zaherg avatar Feb 29 '20 13:02 zaherg

While I do like this new syntax, I'll have to think about the ramifications of such a breaking change before going ahead with it.

schlessera avatar Mar 24 '20 16:03 schlessera

No worries, if there is anything I can help with let me know

zaherg avatar Mar 24 '20 17:03 zaherg

Proceeding with https://github.com/wp-cli/wp-cli/issues/5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/454c165bbc061d094ecc6bf3ec4ec728 in case this PR is auto-closed or broken in some way.

danielbachhuber avatar Nov 18 '22 16:11 danielbachhuber