scaffold-command icon indicating copy to clipboard operation
scaffold-command copied to clipboard

child-theme throws an error if the --path argument is set

Open michaelandre0 opened this issue 4 years ago • 6 comments

Bug Report

I am trying to create a child theme using the following command:

wp scaffold child-theme child-slug --parent_theme=parent-slug --theme_name="My child theme" --activate --path=../mywpsite/

It then throws this error:

Error: Invalid theme slug specified. The target directory '/home/clients/0000000000/myfolder/../mywpsite/wp-content/themes/child-slug' is not in '/home/clients/0000000000/myfolder/../mywpsite/wp-content/themes'.

  • The command is being run from the folder ~/myfolder/
  • The target wordpress install is located in ~/mywpsite/ so I need to set --path=../mywpsite/

However, if I execute the command directly from the ~/mywpsite/ folder, it works fine, but the folder has to exist before or I get the following error.

Success: Created '/home/clients/0000000000/mywpsite/wp-content/themes/child-slug'. Error: The theme directory "child-slug" does not exist.

BUT, the folder AND files still have been created.

That being said, I need to have it work with the --path argument, so I'm assuming this is a bug.

How can this be fixed ?

Thank you

michaelandre0 avatar Feb 26 '20 10:02 michaelandre0

Just noticed that this issue is the same as mine. https://github.com/wp-cli/scaffold-command/issues/263

There is a str_replace line that needs to be wrapped with realpath to fix the issue.

NickStallman avatar May 14 '20 00:05 NickStallman

Looks like this is still relevant, but the attached PR got closed by accident.

It could be restored from https://gist.github.com/danielbachhuber/2951826b5cee4db3c8245ff095d5b7de though.

@NielsdeBlaauw would you be interested in giving this another go?

swissspidy avatar Nov 10 '23 16:11 swissspidy

In this issue, are we talking about Windows setup? In Mac, I am not being able to reproduce the mentioned issue.

ernilambar avatar Apr 22 '24 10:04 ernilambar

In this issue, are we talking about Windows setup? In Mac, I am not being able to reproduce the mentioned issue.

Since I posted this, and considering how the paths look like I would say it wasn't a Windows environment but I can't remember for sure since it was 4 years ago. However I do use Windows for many devs and it could be a possibility.

michaelandre0 avatar Apr 22 '24 11:04 michaelandre0