Standardize separator used in switches (- vs _)

[catchmyfame]

Going through the various WP CLI commands and their switches/options, I noticed there's no standard in terms of word separators (_ vs -) for switches that have more than one word (not with regard to the initial --).

For example, these switches use a hyphen: --extra-php, --skip-salts, --admin-email, --skip-email

But these switches use an underscore: --post_id, --admin_user, --admin_password, --exclude_tables, --size_format.

It would be helpful if it was one or the other, and not both.

[gitlost]

Yes agree @catchmyfame it's an annoying inconsistency.

[schlessera]

The separator is generally -, and this is used pretty much consistently.

The switches you see that have an underscore are normally of the type: --<WordPress Field>=<value>. The underscore comes from the fact that these are mapped to existing WordPress fields/keys, which already contain the underscore.

[danielbachhuber]

Previously https://github.com/wp-cli/wp-cli/issues/1122#issuecomment-159015640