l5kit icon indicating copy to clipboard operation
l5kit copied to clipboard

Consider removing 'simulated_dataset' attribute from SimulationOutput

Open theDebugger811 opened this issue 3 years ago • 1 comments

Currently, the class SimulationOutput has two attributes simulated_dataset and recorded_dataset which are instances of EgoDataset and can be removed. This will help to increase computational efficiency for downstream processes as well.

theDebugger811 avatar Jul 01 '21 07:07 theDebugger811

Hi @theDebugger811

which are instances of EgoDataset and can be removed

We need to keep a reference to the datasets for visualisation and some future metrics. We could use a ChunkedDataset instead of EgoDataset. Tbh it would be better to remove all other fields and leave only those twos (as all other fields derive from them anyway)

lucabergamini avatar Jul 01 '21 09:07 lucabergamini