GetGlyphSpan(Font font, string text) Is it okay not to check for null here?

[yumaojun]

file \source\SkiaSharp.TextBlocks\TextShaper.cs

Is it okay not to check for null here?

public GlyphSpan GetGlyphSpan(Font font, string text)
        {

            GlyphSpan shape = null;

            **if (GlyphSpanCache != null)**
                lock (CacheLock)
                {
                    GlyphSpanCache.TryGetValue((font, text), out shape);
                }

[wouterst79]

yeah, that looks like it would make more sense

[yumaojun]

Thank you for your reply