kirby-git icon indicating copy to clipboard operation
kirby-git copied to clipboard

Not working with Kirby devkit

Open georgobermayr opened this issue 6 years ago • 0 comments

Hi,

when I try to install the plugin with the Kirby devkit my site goes down with this errors in console:

[16-Oct-2018 11:12:47 UTC] PHP Warning:  Use of undefined constant DS - assumed 'DS' (this will throw an Error in a future version of PHP) in /Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-git/index.php on line 3
[16-Oct-2018 11:12:47 UTC] PHP Warning:  require_once(/Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-gitDSGitHelper.php): failed to open stream: No such file or directory in /Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-git/index.php on line 3
[16-Oct-2018 11:12:47 UTC] PHP Fatal error:  require_once(): Failed opening required '/Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-gitDSGitHelper.php' (include_path='.:/Applications/MAMP/bin/php/php7.2.8/lib/php') in /Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-git/index.php on line 3

I think this is an issue with devkit and / or Composer.

If I add something like defined('DS') ? null : define('DS', DIRECTORY_SEPARATOR); to your index.php it works. But I think there should be a better solution?

Thank you, Georg

georgobermayr avatar Oct 16 '18 11:10 georgobermayr