AZSentinel icon indicating copy to clipboard operation
AZSentinel copied to clipboard

Fix/mitretactics

Open Phrozyn opened this issue 2 years ago • 0 comments

Summary of the Pull Request

Adds missing mitre tactic to comments and enum, per error recieved in deployment of rules: Error: expected tactics.0 to be one of [Collection CommandAndControl CredentialAccess DefenseEvasion Discovery Execution Exfiltration Impact InitialAccess LateralMovement Persistence PrivilegeEscalation PreAttack], got ResourceDevelopment

Removes CRLF in two doc files modified: AzSentinel/docs/New-AzSentinelAlertRule.md modified: AzSentinel/docs/New-AzSentinelHuntingRule.md

...

References

Not to my knowledge ...

PR Checklist

By submitting this pull request, I confirm the following:

please fill any appropriate checkboxes, e.g: [X]

  • [ ] Closes #xxx
  • [ ] Requires documentation to be updated
  • [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx
  • [ ] I have made only one major change in my proposed changes.
  • [ ] I have commented my proposed changes within the code.
  • [ ] I have tested my proposed changes, and have included unit tests where possible.
  • [ ] It is compatible with the MIT License
  • [ ] I have squashed any insignificant commits. (git rebase)

A detailed description, screenshots (if necessary), as well as links to any relevant issues

Files changed: modified: AzSentinel/Public/New-AzSentinelAlertRule.ps1 modified: AzSentinel/Public/New-AzSentinelHuntingRule.ps1 modified: AzSentinel/docs/New-AzSentinelAlertRule.md modified: AzSentinel/docs/New-AzSentinelHuntingRule.md modified: AzSentinel/enums/Tactics.ps1

Validation Steps Performed

A detailed description of thew validation steps

Rules deploy satisfactorily with relevant tactics.


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.

Phrozyn avatar Aug 03 '22 22:08 Phrozyn