wormhole
wormhole copied to clipboard
"ethers" is being included as a devDependency
Hi,
With the SDK, the ethers package is being included as a devDependency which means that it has to be installed separately when using the package.
This should be a dependency instead.
Thanks, Cain.
I got the same problem too.
Error: Cannot find module 'ethers/lib/utils'
Require stack:
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/utils/aptos.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/utils/index.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/rpc/getSignedVAAWithRetry.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/rpc/index.js
- /Users/abehjati/src/pyth/pyth-crosschain/ethereum/node_modules/@certusone/wormhole-sdk/lib/cjs/index.js
Likely, the entire SDK should be switched to using peer-dependencies for these sorts of things.
Well.. if the types are used in the package type definitions then maybe it should be marked as dependency, shouldn't it? Or then again everyone needs to skip lib type check.