wormhole-foundation
node(governor): reobservations should not flow cancel
Reobservations are complicated to reason about in a context where flow cancel is enabled. Disabling reobservations is simpler, with only a minor downside that otherwise-eligible reobservations of token transfers will not flow cancel.
Should we be checking these in other spots? I've listed two below but may be missing some others.
If we don't check on the database reload if something was a reobservation or not then wouldn't this lead to more funds being flow-cancelled than it should be?
On GetNotionalAvailableByChain(), we wouldn't want to include these transfers either.
I think this would require us to modify the storage semantics of the transfer to include whether or not something was a reobservation though. Hmmm.
Putting this on pause for now until we have a longer discussion about it.
#4428 should ensure that IsReobservation can be loaded from the Governor codebase which should help this feature assuming we still want to go ahead with it.