WorldDynamics.jl
WorldDynamics.jl copied to clipboard
worlddynamics
An open-source framework written in Julia for global integrated assessment models.
The branch `dev_varcon` [proposes a `variable_connections` function](https://github.com/natema/WorldDynamics.jl/blob/5dd337d1ab4146f8f98397440aaea6a1afd32247/src/solvesystems.jl#L4-L36) which automatically computes connection among components, **under the assumption that all variables have unique names across subsystems**. After polishing the function (i.e. adding...
As noted in https://github.com/worlddynamics/WorldDynamics.jl/issues/114#issuecomment-1542412937, the functions running the different scenarios should be update to match the original solver employed in Vensim. We should also document such default solvers somewhere, probably...
Some functions, e.g. `interpolate`, are restricted to take only `Float64` inputs. We should remove such unnecessary restriction.
The [docstring of `interpolate`](https://github.com/worlddynamics/WorldDynamics.jl/blob/f9cfc8a6f510cf82f66ec0fd2a938adb494f44aa/src/functions.jl#L6-L9) currently cite a non-existent fourth argument ("an increment value"). This should be fixed, and the docstring should be expanded to include a clear explanation of what...
In the tutorial [Implementing a new model](https://worlddynamics.github.io/WorldDynamics.jl/stable/tutorial/#Implementing-a-new-model) we have a lot of `using` statements, some of which I think are unnecessary. In fact, a first `using ModelingToolkit` is missing in...
After the implementation of the `variable_connections` function, it would be nice to be able to use it also in cases where scenarios are modified by adding subsystems, as happens for...
In [`common_pop`, we need to initialize `fpu`, `lmf` and `cmi` explicitly](https://github.com/worlddynamics/WorldDynamics.jl/blob/6d01563db3c6187e4aa19923ec3a588fb27577e8/src/World3/population/common_pop/subsystems.jl#L13-L15) for the [plots in `pop15` ](https://github.com/worlddynamics/WorldDynamics.jl/blob/6d01563db3c6187e4aa19923ec3a588fb27577e8/src/World3/population/pop15/plots.jl) to work. Why is that the case?
https://github.com/worlddynamics/WorldDynamics.jl/blob/1ea057e847a170bb38a1726b7e872f9c3fc7b9ae/src/functions.jl#L9 - What about enforcing one-line-per-sentence in docstrings? - The definition of interpolate is unclear and can be improved, in particular when we say `by linearly interpolating the function itself...
So far the tests are restricted to check if scenarios and figures codes run.
https://github.com/worlddynamics/WorldDynamics.jl/blob/3fcc7400b9b393835e4b463d8ad3267b9021723c/src/functions.jl#L4 I suggest to rename $x_n$ and $y_n$ as $x_2$ and $y_2$ to emphasize that it's just a line, and to typize the arguments (`Number`?)
Metadata
Owner
Metadata
An open-source framework written in Julia for global integrated assessment models.