semaphore-rs

semaphore-rs copied to clipboard

Currently has a runtime error :(

recmo

Unsafe usage of `from_raw_parts` and `from_raw_parts_mut`

1

We use these functions in a few places without ensuring that the types we're converting into can be converted to. For example: ``` pub fn new_with_initial_values( file_path: PathBuf, initial_value: &H::Hash,...

Dzejkop

Resolve TODO: How does it handle strings that are to short?

1

[TODO](https://github.com/worldcoin/semaphore-rs/blob/1fa1471a13539af2f859478a0c9108adfe7535ca/src/util.rs#L49)

Dzejkop

Not a big concern, since we never have other processes using the mmapped file, but the safety requirements of [`MmapOptions::with_file`](https://docs.rs/mmap-rs/0.6.0/mmap_rs/struct.MmapOptions.html#method.with_file) demand that we have exclusive mutable access to the file....

Dzejkop

[TODO](https://github.com/worldcoin/semaphore-rs/blob/1fa1471a13539af2f859478a0c9108adfe7535ca/src/field.rs#LL7C10-L7C44)

Dzejkop

[TODO](https://github.com/worldcoin/semaphore-rs/blob/1fa1471a13539af2f859478a0c9108adfe7535ca/src/merkle_tree.rs#L120)

Dzejkop

0xForerunner