test-anything icon indicating copy to clipboard operation
test-anything copied to clipboard

Published 20 hours ago • verified publisher icon workshopper

add i18n support

Open tgfjt opened this issue 9 years ago • 6 comments

Hi! @finnp

This PR is for i18n support:smile: with workshopper-adventure. also I added verify.js instead of adventure-verify, because it doesn't tap logs so I added this line. https://github.com/tgfjt/test-anything/blob/workshopper-adventure/verify.js#L58

tgfjt avatar Apr 16 '15 15:04 tgfjt

For examples, we need these files in case of Japanese Translation:

  • i18n/ja.json
  • exercise/xxx/instruction_ja.md
  • exercise/log-it-out/messages_ja.json

but I've not translated yet!

tgfjt avatar Apr 16 '15 15:04 tgfjt

Thanks a lot for taking the time to do this!

I am not sure about that verify fix though. Seems to me like it is a bug in workshopper-adventure. @martinheidegger What do you think? The result of verify should be piped to stdout automaticcaly by workshopper-adventure.

finnp avatar Apr 16 '15 16:04 finnp

It's not only piping but also logging [object object]. I've read the code but I don't understand compatibily for other workshopper...

tgfjt avatar Apr 19 '15 22:04 tgfjt

I didn't implement streaming yet (I knew i forgot something!), it has to have an API change here and some additions in here and at a few other places.

Btw.: I am in the process of refactoring the workshopper: refactoring branch to make it better readable.

martinheidegger avatar Apr 20 '15 04:04 martinheidegger

Thanks, I see.. This request might be too hurry :wink: I'll try something to support streaming.

tgfjt avatar Apr 20 '15 04:04 tgfjt

@finnp Hi! I think that it's finally done. (Great @martinheidegger wrote it almost.:smile: )

Would you review it?

Thanks.

tgfjt avatar Oct 26 '15 05:10 tgfjt