scope-chains-closures
scope-chains-closures copied to clipboard
workshopper
Translation to japanese
We started the translation of scope-chains-closures to japanese. (based on [email protected]). PR in progress
Wow, this is excellent work! Thank you so much.
I'll have a more thorough review when I get around to it (and when you complete the PR).
One thing I'd like to point out now: 4a32ff0 "Removed line breaks" - I would prefer to keep the breaks in. It makes diffs smaller and easier to read. Also, when outputting in the console, it keeps it to a maximum line length removing the whole-screen-width issue of reading long text.
About the line-breaks: I adapted msee to have line-break support. Its clunky and slow but it should work. However: the line-breaks in the text are considered "important" and thus - unless its written in one line - it will not be properly adjusted in size. There is still an performance issue with the msee feature https://github.com/tokuhirom/visualwidth-js/issues/8 . I wonder if it should be changed so blocks are treated as blocks until a empty line or indentation change happens?!
However: the line-breaks in the text are considered "important"
Yeah, msee got that wrong originally anyway (single linebreaks in Markdown should be unimportant, but double breaks important).
It looks like your changes are not correctly wrapping the lines:
line breaks (before)
no line breaks (now)
Due to the move of the binary file, you'll need to update the main & bin keys in package.json:
"main": "runner.js",
"bin": {
"scope-chains-closures": "runner.js",
"sccjs": "runner.js"
},
Don't forget the sccjs alias.
Once the PR is complete, I'll also need to confirm the translations (for sanity's sake) - is Google Translate up to the task for at least a sort-of-accurate once over?
Thank you for further reviewing. Google Translate is absolutely unusable (yet still the best class) for the task. Either hire a person or trust the community in case of Japanese.
About the package.json: Will do.
About msee: It will take me some time to fix msee. (line breaks in terminal are a pita - due to double-width characters in some languages ... )
If you don't mind: I will close this PR and come back with two separate ones. One for moving to workshopper-adventure structure and another one that does translation to japanese.
Hi all, First of all, thanks a lot for this excellent course in nodeschool.
@martinheidegger, I've met you at nodeschool Osaka and your Japanese was excellent. I'm pretty sure there won't be much misconception about your translation, but maybe I can help in reviewing the contents. Please let me know if I can help. I'm looking forward in the Japanese version and wish I can share it with my colleagues, too.
