workos-node icon indicating copy to clipboard operation
workos-node copied to clipboard

adding three new conection types to node SDK connection type enums

Open rarevalo13 opened this issue 1 month ago • 1 comments

Description

Added the following connection types:

CleverOIDC
EntraIdOIDC
OktaOIDC

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

rarevalo13 avatar Nov 20 '25 17:11 rarevalo13

Greptile Overview

Greptile Summary

Added three new OIDC connection types (CleverOIDC, EntraIdOIDC, OktaOIDC) to the ConnectionType enum to expand SSO provider support.

  • All three values added in correct alphabetical order
  • Minor style inconsistency: new types use OIDC (caps) while some existing types like AdpOidc and LoginGovOidc use Oidc (camelCase), though GenericOIDC already uses caps
  • No functional issues; changes are limited to enum definition

Confidence Score: 5/5

  • Safe to merge - simple enum additions with no logic changes
  • This is a straightforward addition of three enum values with no behavioral changes, proper alphabetical ordering, and no security concerns
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/sso/interfaces/connection-type.enum.ts 4/5 Added three new OIDC connection types in alphabetical order; minor casing inconsistency with existing enum values

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Enum as ConnectionType Enum
    participant SDK as WorkOS SDK
    participant API as WorkOS API

    Dev->>Enum: Add CleverOIDC, EntraIdOIDC, OktaOIDC
    Note over Enum: New connection types<br/>added to enum
    
    SDK->>Enum: Import ConnectionType
    SDK->>API: Send connection request<br/>with new type
    API-->>SDK: Handle new connection types
    SDK-->>Dev: Return connection response

greptile-apps[bot] avatar Nov 20 '25 17:11 greptile-apps[bot]