gitpay icon indicating copy to clipboard operation
gitpay copied to clipboard

Fix Lint issues

Open alexanmtz opened this issue 1 year ago • 6 comments

When you do a push you will see many lint errors, and we need all those fixes so we can have the push hook green

alexanmtz avatar Jan 12 '24 14:01 alexanmtz

@KenjxJJ can you work on this?

alexanmtz avatar Jan 15 '24 13:01 alexanmtz

Yes.

KenjxJJ avatar Jan 16 '24 11:01 KenjxJJ

Hi @alexanmtz , I would like to work on this if there is no resolution yet.

effaf avatar Feb 09 '24 18:02 effaf

Hello @effaf , there's no resolution yet; feel free to work on it.

alexanmtz avatar Feb 09 '24 18:02 alexanmtz

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix . , and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

effaf avatar Feb 10 '24 04:02 effaf

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix . , and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

Hey, @effaf, thanks for jumping into this issue and your proactivity. You can change the ecmaVersion in the configuration, and we can eliminate all console.logs except the one with the comment // eslint-disable-next-line no-console

And we can remove the unused libraries.

alexanmtz avatar Feb 10 '24 12:02 alexanmtz

Hey @effaf, some progress on this one?

alexanmtz avatar May 29 '24 19:05 alexanmtz

There's a bounty of $20 for this one: https://gitpay.me/#/task/840

alexanmtz avatar Jun 10 '24 07:06 alexanmtz

There's a bounty of $20 for this one: https://gitpay.me/#/task/840

I started working on this issue. I saw the comments above and will take them into consideration

guvitorino avatar Jun 13 '24 01:06 guvitorino

That's great @guvitorino, looking forward to review your solution and feel free to change the configuration as suggested before

and fix automatically some issues with npm run lint-fix

alexanmtz avatar Jun 13 '24 08:06 alexanmtz

hi i am also doing this

Anshgrover23 avatar Jun 13 '24 14:06 Anshgrover23

/attempted Fix Lint issues #1038, plss check @alexanmtz also there is some parsing error were not resolving can u plss check

Anshgrover23 avatar Jun 13 '24 14:06 Anshgrover23

/claim #1038

Anshgrover23 avatar Jun 14 '24 05:06 Anshgrover23

/claim #1038

CodeWithInferno avatar Jun 14 '24 07:06 CodeWithInferno

Hello @Anshgrover23 , thanks for sending the PR, I will review in the weekend and when it's merged you can claim the bounty on the web page by going in "Solve issue" and pasting your PR when is merged in "Send Solution" tab

alexanmtz avatar Jun 14 '24 09:06 alexanmtz

Hey @guvitorino, we have already a PR to review for this one, so let's find another issue for you :)

alexanmtz avatar Jun 14 '24 09:06 alexanmtz

@alexanmtz thanks buddy, waiting for your merge reply and thanks for giving me chance

Anshgrover23 avatar Jun 14 '24 09:06 Anshgrover23

@alexanmtz made some more commit changes review the pr once again please sir.

Anshgrover23 avatar Jun 15 '24 13:06 Anshgrover23

@alexanmtz solved the optonal chaining errors . check new commit

Anshgrover23 avatar Jun 16 '24 09:06 Anshgrover23

Hey @raviteja83, you fixed this issue successfully; many thanks for the contribution 🚀

You can claim your bounty by visiting this issue on Gitpay: https://gitpay.me/#/profile/task/840/fix-lint-issues

On "Solve Issue" and on the "Send Solution" tab, you can paste the PR merged and the Bounty process will be initiated I hope :)

alexanmtz avatar Jun 24 '24 09:06 alexanmtz