orchestrator-core icon indicating copy to clipboard operation
orchestrator-core copied to clipboard

Improve Websocket Broadcasting Stability

Open Mark90 opened this issue 1 year ago • 1 comments

  • Make RedisBroadcast retry in case of connection errors/timeouts
  • Fix RedisBroadcast not releasing redis connection
  • Extend logging in BroadcastWebsocketManager and catch exceptions
  • Fixed some tests, updated pre-commit
  • Bump version to 2.7.4

Mark90 avatar Aug 19 '24 10:08 Mark90

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (b9f0920) to head (17bade7). Report is 5 commits behind head on main.

Files Patch % Lines
.../websocket/managers/broadcast_websocket_manager.py 76.00% 5 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   83.44%   83.43%   -0.01%     
==========================================
  Files         188      188              
  Lines        9266     9287      +21     
  Branches     1520     1523       +3     
==========================================
+ Hits         7732     7749      +17     
- Misses       1271     1274       +3     
- Partials      263      264       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 19 '24 11:08 codecov[bot]