orchestrator-core icon indicating copy to clipboard operation
orchestrator-core copied to clipboard

[Feature]: The generator doesn't correctly yield a working confirmation_email

Open acidjunk opened this issue 1 year ago • 1 comments

I'm working on an email confirmation step: which uses a single dispatch to generate the mail. With a bit of extra effort it should be possible to add this to the example orchestrator as well.

Encountered some things:

  • a lot of logic in the SURF app is SAP specific or Product specific: I'm removing these part and replace it for templates that render all domain model attributes
  • 2 or 3 languages are used in SURF
  • GUI needs a CC list: or it crashes on dispaling the mail in a workflow step

Proposal:

  • I am working on a POC, happy to open a PR to example-orchestrator, regarding a simple mail setup. Which implements the boilerplate. A folder in the services folder and file with some utilities + Jinja templates without branding.
  • Also a single dispatch function that uses a smart way to indicate which domain model attribute you want to show under which label: which gives you a somewhat generic way of dealing with domain models.

Out of scope (for me), now: Fixing the generator itself.

acidjunk avatar Mar 15 '24 23:03 acidjunk

Could add this to the generator to generate skeleton single dispatch code to implement this feature.

hanstrompert avatar Mar 03 '25 10:03 hanstrompert